W-23795356- resolve binaries from PATH to prevent CWD-based RCE - #538
Open
soridalac wants to merge 1 commit into
Open
W-23795356- resolve binaries from PATH to prevent CWD-based RCE#538soridalac wants to merge 1 commit into
soridalac wants to merge 1 commit into
Conversation
WillieRuemmele
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Summary
shelljs.which()inGenerator.execute()before passing toshelljs.exec(), preventing Windows CWD-firstresolution from executing planted binaries
flag.tsto route throughGenerator.execute()instead of callingshelljs.execdirectlycommand.ts(sf) andplugin.ts(git)bin/dev.cmd)Verification
calc.exepopupsCould not find "yarn" on PATH— no executionTest Plan
sf-yarn-rce-pocno longer triggerscalc.exesf dev generate commandworks normally against linked pluginWhat issues does this PR fix or reference?
@W-23795356@